Skip to content

Start to support Overleaf 5.1.1#58

Open
armanddidierjean wants to merge 4 commits intosmhaller:masterfrom
aeecleclair:5.1.1
Open

Start to support Overleaf 5.1.1#58
armanddidierjean wants to merge 4 commits intosmhaller:masterfrom
aeecleclair:5.1.1

Conversation

@armanddidierjean
Copy link
Copy Markdown

@armanddidierjean armanddidierjean commented Sep 29, 2024

Hello,

This PR was made to try to make #50 progress.

I used two great sources to begin this pull request:

  • Branch 5.0.6, by @smhaller was really interesting, but a bit complex: it did not support Overleaf 5.1.1 and tried to integrate new features like the TrackChange manager and the login page bypass when only OAuth is enabled.
  • @davrot made really useful modifications in his fork but did not support the promise based syntax.

The purpose behind this PR is to propose only changes related to 5.1.1 support. This pull request does not provide a complete support for 5.1.1

Suggestions and review are really welcome. If this PR can help someone in the process of updating ldap-overleaf-sl to support Overleaf 5.1.1, feel free to use it and improve it.

Implemented changes

  • Update diff files over overleaf 5.1.1 codebase
  • Use the new promise based syntax instead of the previous callback based one
  • Update environment variables to prefix them with OVERLEAF
  • Use Mongo 5 in docker compose examples
  • Replace navbar.pug by navbar-website-redesign.pug

OAuth 2

OAuth 2 was tried against a provider, and should work. Only a few changes were related to OAuth.

LDAP

LDAP features are partially updated for 5.1.1. Changes made are mostly related to the use of the promise based syntax.
Currently, LDAP features does not work, and are commented out in this PR.
If someone manages to fix them, help would be really appreciated.

Update to V5

Migrations steps are required to update to V5, especially for the database migration.
Users should also update environment variables and volume mounts : https://github.com/overleaf/overleaf/wiki/Release-Notes-5.x.x#mongodb-upgrade-to-v5
Documentation needs to be written on this subject

close #50

@yzx9
Copy link
Copy Markdown
Collaborator

yzx9 commented Sep 30, 2024

Great work! It seems that there may be an issue with LDAP. I should have some time later to take a look at it.


Updated: Sorry for the delay. I have to mention that this project requires a better development environment. it's quite difficult to debug with LDAP at the moment.

@maurerle
Copy link
Copy Markdown
Contributor

maurerle commented Nov 7, 2024

Hi, is there any update on this?

@smhaller
Copy link
Copy Markdown
Owner

I will have a look into this pull request in the upcoming week - sorry for the delay.

@fussel132
Copy link
Copy Markdown

Current sharelatex version is 5.3.0, an update would be very cool

@HighwayStar
Copy link
Copy Markdown

Updated: Sorry for the delay. I have to mention that this project requires a better development environment. it's quite difficult to debug with LDAP at the moment.

have you tried to run overleaf in dev mode? https://github.com/overleaf/overleaf/tree/main/develop It will mount actual source inside docker and apply code changes to running code.

@davrot
Copy link
Copy Markdown

davrot commented Mar 19, 2025

I wonder if the effort of the individual Overleaf "repair" projects can be combined somehow...
There is an up-to-date and working implementation by @yu-i-i under:
https://github.com/yu-i-i/overleaf-cep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Patches for Version 5

7 participants