-
Notifications
You must be signed in to change notification settings - Fork 6
Fix Show Attribution for Enhanced Selfie Flow #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
showInstructions && !acknowledgedInstructions -> SelfieCaptureInstructionScreenEnhanced( | ||
modifier = Modifier.fillMaxSize(), | ||
showAttribution = showAttribution, | ||
) { | ||
acknowledgedInstructions = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The showAttribution
parameter is being passed to SelfieCaptureInstructionScreenEnhanced
, but there's no corresponding parameter in the function call before this change. Make sure the SelfieCaptureInstructionScreenEnhanced
function actually accepts this parameter to avoid compilation errors. [possible issue, importance: 5]
showInstructions && !acknowledgedInstructions -> SelfieCaptureInstructionScreenEnhanced( | |
modifier = Modifier.fillMaxSize(), | |
showAttribution = showAttribution, | |
) { | |
acknowledgedInstructions = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine to me. Tested on the sample app and the attribution can be switch on and off. @tobitech please bump the https://github.com/smileidentity/android/blob/main/lib/VERSION as well.
User description
Story: https://app.shortcut.com/smileid/story/xxx
Summary
Known Issues
N/A.
Test Instructions
showAttribution
argument values toSmartSelfieEnrollmentEnhanced
inMainScreen.kt
and run the sample app to see if it takes effect.Screenshot
N/A.
PR Type
Bug fix
Description
Changes walkthrough 📝
SelfieCaptureScreenEnhanced.kt
Add showAttribution parameter to instruction screen
lib/src/main/java/com/smileidentity/compose/selfie/enhanced/SelfieCaptureScreenEnhanced.kt
showAttribution
parameter to theSelfieCaptureInstructionScreenEnhanced
function call