Skip to content

Fix Show Attribution for Enhanced Selfie Flow #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

Conversation

tobitech
Copy link
Collaborator

@tobitech tobitech commented May 19, 2025

User description

Story: https://app.shortcut.com/smileid/story/xxx

Summary

  • Add missing showAttribution parameter to instructions screen for selfie capture enhanced.

Known Issues

N/A.

Test Instructions

  • You can pass in showAttribution argument values to SmartSelfieEnrollmentEnhanced in MainScreen.kt and run the sample app to see if it takes effect.

Screenshot

N/A.


PR Type

Bug fix


Description

  • Add missing showAttribution parameter to instructions screen

Changes walkthrough 📝

Relevant files
Bug fix
SelfieCaptureScreenEnhanced.kt
Add showAttribution parameter to instruction screen           

lib/src/main/java/com/smileidentity/compose/selfie/enhanced/SelfieCaptureScreenEnhanced.kt

  • Added missing showAttribution parameter to the
    SelfieCaptureInstructionScreenEnhanced function call
  • Ensures attribution is properly displayed when configured
  • +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @tobitech tobitech self-assigned this May 19, 2025
    @tobitech tobitech requested a review from a team as a code owner May 19, 2025 10:40
    @prfectionist
    Copy link
    Contributor

    prfectionist bot commented May 19, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Comment on lines 171 to 175
    showInstructions && !acknowledgedInstructions -> SelfieCaptureInstructionScreenEnhanced(
    modifier = Modifier.fillMaxSize(),
    showAttribution = showAttribution,
    ) {
    acknowledgedInstructions = true
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggestion: The showAttribution parameter is being passed to SelfieCaptureInstructionScreenEnhanced, but there's no corresponding parameter in the function call before this change. Make sure the SelfieCaptureInstructionScreenEnhanced function actually accepts this parameter to avoid compilation errors. [possible issue, importance: 5]

    Suggested change
    showInstructions && !acknowledgedInstructions -> SelfieCaptureInstructionScreenEnhanced(
    modifier = Modifier.fillMaxSize(),
    showAttribution = showAttribution,
    ) {
    acknowledgedInstructions = true

    Copy link
    Contributor

    @robin-smileid robin-smileid left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Code changes look fine to me. Tested on the sample app and the attribution can be switch on and off. @tobitech please bump the https://github.com/smileidentity/android/blob/main/lib/VERSION as well.

    JNdhlovu
    JNdhlovu previously approved these changes May 19, 2025
    @tobitech tobitech merged commit 41269df into main May 19, 2025
    3 checks passed
    @tobitech tobitech deleted the fix-showAttribution branch May 19, 2025 11:34
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants