-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentry Integration for SDK #278
Open
tobitech
wants to merge
14
commits into
main
Choose a base branch
from
sdk-sentry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
502550d
add sentry dependency to podspec and run pod install.
tobitech 6810570
add sentry dependency to spm
tobitech 6f67fe9
set a version for sentry in podspec and podfile.
tobitech 17e5c96
initialise sentry when sdk is initialised
tobitech ecf2722
scope configuration for sentry sdk
tobitech 68d8131
code that will be later removed
tobitech bc5d082
correct key value position
tobitech 385e72e
introduce a new error reporting protocol and sentry error reporter cl…
tobitech e131903
introduce arkana keys to the SDK
tobitech 69c8647
install generated ArkanaKeys code as packages for SPM and Cocoapods d…
tobitech 386652a
Merge branch 'main' into sdk-sentry
tobitech 9409c88
run pod install
tobitech 516ed5f
remove testing code
tobitech 4347f6e
add a flag to SmileID Initializer to enable or disable error reporting.
tobitech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
global_secrets: | ||
- SENTRY_DSN | ||
package_manager: cocoapods |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import ArkanaKeys | ||
import Sentry | ||
|
||
protocol ErrorReportingService { | ||
func captureError(_ error: any Error, userInfo: [String: Any]?) | ||
} | ||
|
||
class SentryErrorReporter { | ||
static let shared: SentryErrorReporter = SentryErrorReporter() | ||
|
||
private let sentryHub: SentryHub | ||
|
||
private init() { | ||
// setup sentry options | ||
let options = Sentry.Options() | ||
options.dsn = ArkanaKeys.Global.sENTRY_DSN | ||
options.releaseName = SmileID.version | ||
options.enableCrashHandler = true | ||
options.debug = true | ||
options.tracesSampleRate = 1.0 | ||
options.profilesSampleRate = 1.0 | ||
|
||
// setup sentry scope | ||
let scope = Sentry.Scope() | ||
scope.setTag(value: SmileID.config.partnerId, key: "partner_id") | ||
let user = Sentry.User() | ||
user.userId = SmileID.config.partnerId | ||
scope.setUser(user) | ||
|
||
// setup sentry hub | ||
let sentryClient = SentryClient(options: options) | ||
self.sentryHub = SentryHub(client: sentryClient, andScope: scope) | ||
} | ||
} | ||
|
||
extension SentryErrorReporter: ErrorReportingService { | ||
func captureError(_ error: any Error, userInfo: [String: Any]? = nil) { | ||
sentryHub.capture(error: error) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ platform :ios, '13.0' | |
target 'SmileID_Example' do | ||
pod 'SmileID', :path => '../' | ||
pod 'netfox' | ||
pod 'Sentry' | ||
pod 'Sentry', '~> 8.43.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want to fix this to a specific Sentry version? |
||
pod 'SwiftLint' | ||
pod 'ArkanaKeys', :path => './ArkanaKeys/ArkanaKeys/' | ||
pod 'ArkanaKeysInterfaces', :path => './ArkanaKeys/ArkanaKeysInterfaces/' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tobitech should this be SENTRY_DSN?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is autogenerated by the tool used to encrypt the Sentry DSN.