Add WebSocket support and launcher #108
Open
+209
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
May 23, 2023
haydenbaker
force-pushed
the
websocket-support
branch
2 times, most recently
from
935b2ff
to
ee271aa
Compare
milesziemer
requested changes
May 24, 2023
haydenbaker
force-pushed
the
websocket-support
branch
from
ee271aa
to
c304f94
Compare
milesziemer
requested changes
May 25, 2023
| try { | ||
| String port = args[0]; | ||
| Optional<Exception> launchFailure; |
There was a problem hiding this comment.
Declaration can go down with the assignment
mtdowling
reviewed
Jul 31, 2023
|
|
||
| #### WebSockets | ||
|
|
||
| Run `./gradlew run --args="3000 --ws"` |
There was a problem hiding this comment.
Can you put --ws in front? I would assume here that 3000 is a positional argument that comes after named arguments, and those are usually last.
There was a problem hiding this comment.
perhaps it's also worth considering the deprecation of port as a positional argument and making it a --port option? For some time the server could support both styles, but eventually the positional way would be dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing:
./gradlew run --args="3000 --ws", confirm a websocket client can connect and communicate with it./gradlew run --args="0", confirm no behavior changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.