Allow server SDKs to replace invalid UTF-8 character with '�' #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drganjoo
force-pushed
the
fahadzub/replace-invalid-utf8
branch
2 times, most recently
from
2e86d87 to
10fb59e
Compare
added 2 commits
February 4, 2025 15:33
…invalid UTF-8 characters with �
drganjoo
force-pushed
the
fahadzub/replace-invalid-utf8
branch
4 times, most recently
from
14fdd2e to
5ffe67d
Compare
drganjoo
force-pushed
the
fahadzub/replace-invalid-utf8
branch
from
5ffe67d to
5ec624b
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
We were considering something like this for the client a few months ago because some customers were encountering non-utf-8 headers from S3: #3830. It broke some of our protocol tests and we decided not to follow it up because there wasn't consistent cross-SDK guidance about how to handle these headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input contains invalid UTF-8 characters (such as surrogate pairs or invalid character ranges), these characters will be replaced with the replacement character "�" (\uFFFD). This replacement only occurs if the codegen flag 'replaceInvalidUtf8' is set to true in
smithy-build-template.json.