Fix Terastallization base power buff for priority moves called by Encore #10808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaWoblefet
reviewed
Jan 10, 2025
sim/battle-actions.ts
Outdated
| @@ -1668,9 +1668,10 @@ export class BattleActions { | |||
| } | |||
|
|
|||
| if ( | |||
| basePower < 60 && source.getTypes(true).includes(move.type) && source.terastallized && move.priority <= 0 && | |||
| basePower < 60 && source.getTypes(true).includes(move.type) && source.terastallized && | |||
| this.dex.moves.get(move.id).priority <= 0 && !move.multihit && | |||
There was a problem hiding this comment.
I would also get the move's true multihit status from move data while you're at it; Tera Electric Parental Bond Nuzzle, for example, will be 60 BP both times.
|
Otherwise this looks good. |
KrisXV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.smogon.com/forums/threads/tera-bp-bump-and-encore.3757856/
"Using a move with priority (like Bullet Punch) forced via Encore will give the move a Tera BP bump to 60 when it should not. This is presumably because Encore is updating the move's priority mid-turn, but Tera BP should be checking the move's priority in move data, not what the move's current priority is."
I don't believe this introduces any collateral bugs.