Skip to content

Conversation

thomaseizinger
Copy link
Contributor

At present, smoltcp only does a single pass of advancing the egress socket state. This means the layer above has to call poll in a loop to ensure sufficient progress has been made.

We already exhaustively progress the ingress state further up so doing the same thing for the egress state seems appropriate.

Copy link

codecov bot commented May 8, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.45%. Comparing base (17012eb) to head (671827b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/iface/interface/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   80.45%   80.45%           
=======================================
  Files          81       81           
  Lines       24461    24461           
=======================================
  Hits        19681    19681           
  Misses       4780     4780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thvdveld
Copy link
Contributor

thvdveld commented Oct 7, 2025

@whitequark @Dirbaio I don't see any reason why not to do this.

@whitequark
Copy link
Contributor

I thought @Dirbaio had a case where this caused an issue?

@thvdveld
Copy link
Contributor

thvdveld commented Oct 7, 2025

I thought that as well and was digging in old issues and PRs, but I didn't find anything related to the egress. Most of the issues were with ingress resulting in a DoS.

@whitequark
Copy link
Contributor

@thomaseizinger Could you re-run/fix the test please? We'll merge it after.

@thomaseizinger
Copy link
Contributor Author

@thomaseizinger Could you re-run/fix the test please? We'll merge it after.

I just accepted the new snapshot but I don't really know what it is testing.

@whitequark whitequark added this pull request to the merge queue Oct 13, 2025
@whitequark
Copy link
Contributor

Thanks!

Merged via the queue into smoltcp-rs:main with commit 39cd44e Oct 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants