Allow empty replies from Resrobot server #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 13, 2018 21:57
Allows callers to parseJson() to check whether the parsing failed. Since
an empty JSON object was returned if the parsing failed, there was no
way to know if the input string was "{}" or if the parsing failed.
Sometimes, the server reply can be empty and still valid. This is for example the case with time table replies when there are no departures from a station (or at least not any departures matching the selected direction). Fixes smurfy#267.
|
hi, sorry, i'm busy with other stuff and also need to reinstall all my QT versions. To test. |
|
No worries. I totally understand if you are busy and know it can be difficult to find the time for spare time projects like this. If you think it's feasible, I would be honoured to get write access to the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the server reply can be empty and still valid. This is for example the case with time table replies when there are no departures from a station (or at least not any departures matching the selected direction).
In order to do this change, I had to modify the signature of
parseJson()to return aQVariantinstead of aQVariantMap, so callers can check if the parsing succeeded in a better way than looking whether the returned map is empty. For symmetry, I also changedserializeToJson()correspondingly.The other two backends using
parseJson()(Matka and NineTwo) have been left with unchanged behaviour, since I'd rather not fix them unless broken.Should solve #267.
@smurfy Please review.