(#122) Apex Legends UNKNOWN_97 -> LIGHTMAP_DATA_UNKNOWN

snake-biscuits · Aug 9, 2023 · 295545a · 295545a
1 parent ced0176
commit 295545a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/bsp_tool/branches/respawn/apex_legends.py b/bsp_tool/branches/respawn/apex_legends.py
@@ -122,7 +122,7 @@ class LUMP(enum.Enum):
     UNUSED_94 = 0x005E
     UNUSED_95 = 0x005F
     UNUSED_96 = 0x0060
-    UNKNOWN_97 = 0x0061
+    LIGHTMAP_DATA_UNKNOWN = 0x0061
     LIGHTMAP_DATA_SKY = 0x0062
     CSM_AABB_NODES = 0x0063
     CSM_OBJ_REFERENCES = 0x0064
@@ -162,7 +162,7 @@ class LUMP(enum.Enum):
 # New:
 #   CM_GRID -> TWEAK_LIGHTS
 #   TEXTURE_DATA_STRING_DATA -> UNKNOWN_43
-#   TRICOLL_BEVEL_INDICES -> UNKNOWN_97
+#   TRICOLL_BEVEL_INDICES -> LIGHTMAP_DATA_UNKNOWN
 #   UNUSED_15 -> SURFACE_NAMES
 #   UNUSED_16 -> CONTENTS_MASKS
 #   UNUSED_17 -> SURFACE_PROPERTIES

diff --git a/bsp_tool/branches/respawn/apex_legends13.py b/bsp_tool/branches/respawn/apex_legends13.py
@@ -115,7 +115,7 @@ class LUMP(enum.Enum):
     UNUSED_94 = 0x005E
     UNUSED_95 = 0x005F
     UNUSED_96 = 0x0060
-    UNKNOWN_97 = 0x0061
+    LIGHTMAP_DATA_UNKNOWN = 0x0061
     LIGHTMAP_DATA_SKY = 0x0062
     CSM_AABB_NODES = 0x0063
     CSM_OBJ_REFERENCES = 0x0064

diff --git a/bsp_tool/extensions/lightmaps.py b/bsp_tool/extensions/lightmaps.py
@@ -274,7 +274,8 @@ def box_tuple(_dict):
 # TODO: auto-detect bytes-per-texel in save_rbsp_r2 instead
 def save_rbsp_r5(rbsp, image_dir="./", ext="png"):
     """Saves to '<image_dir>/<rbsp.filename>.sky.lightmaps.png'"""
-    # NOTE: pass rbsp.external to extract from .bsp_lumps
+    # NOTE: pass rbsp.external to extract from .bsp_lumps (essential for season 11 onwards)
+    # TODO: LIGHTMAP_DATA_UNKNOWN if present
     sky_lightmaps = list()
     sky_start, sky_end = 0, 0
     rtl_lightmaps = list()