Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract cache logic from getScores #941

Open
wants to merge 5 commits into
base: extract-cache
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 30, 2023

Fix #939

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (7921024) 75.00% compared to head (b78d40d) 72.27%.
Report is 3 commits behind head on extract-cache.

Additional details and impacted files
@@                Coverage Diff                @@
##           extract-cache     #941      +/-   ##
=================================================
- Coverage          75.00%   72.27%   -2.73%     
=================================================
  Files                 12       12              
  Lines                664      689      +25     
  Branches             111      108       -3     
=================================================
  Hits                 498      498              
- Misses               163      188      +25     
  Partials               3        3              
Files Coverage Δ
src/metrics.ts 63.15% <100.00%> (+6.90%) ⬆️
src/scores.ts 84.09% <58.82%> (-15.91%) ⬇️
src/helpers/cache.ts 73.13% <33.33%> (-26.87%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wa0x6e wa0x6e changed the base branch from master to extract-cache October 30, 2023 10:03
@wa0x6e wa0x6e added this to the Add more metrics milestone Oct 30, 2023
@wa0x6e wa0x6e requested a review from ChaituVR November 28, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant