-
Notifications
You must be signed in to change notification settings - Fork 194
fix: remove turbo column
#1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: remove turbo column
#1015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the legacy turbo column and flag, relying entirely on turbo_expiration as the source of truth for a space’s turbo status.
- Deletes
turbofrom fixtures, schema, queries, and mappings - Simplifies
isTurbohelper, updates metrics collection logic, and refactors GraphQL operations - Adjusts tests to drop
turbo, fix async assertions, and add a turbo-expiration scenario
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/fixtures/spaces.ts | Removed deprecated turbo property from fixtures |
| test/e2e/space.test.ts | Dropped turbo in tests, corrected missing matcher on status, added turbo scenario |
| src/helpers/spaces.ts | Simplified isTurbo signature and removed turbo from SQL/query mapping |
| src/helpers/schema.sql | Dropped turbo column and its index |
| src/helpers/metrics.ts | Replaced turbo count with turbo_expiration, refactored async loop |
| src/graphql/operations/* | Removed spaces.turbo field from all GraphQL queries |
| src/graphql/helpers.ts | Updated formatting helpers to compute turbo from turboExpiration |
Comments suppressed due to low confidence (1)
test/e2e/space.test.ts:29
- This assertion is missing a matcher and doesn't actually validate the status code. Consider using something like expect(response.status).toBe(200) to verify the expected HTTP status.
expect(response.status);
25b832d to
431e256
Compare
20bbf0e to
70020d4
Compare
|
We updated |
Done for most of them, still a few remaining. This PR should be merge only once @bonustrack confirmed that it's done, then if everything working, we could delete the |
|
Not all the space are updated, we still miss the spaces who got free turbo because of their network plan. Will update here once its done |
|
@bonustrack whats the latest on this |
This PR removes usage of the
turbocolumn to get a space turbo status, and will rely entirely on theturbo_expirationcolumn as the unique source of truth for a space's turbo status