Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Labels on proposal #449

Merged
merged 3 commits into from
Oct 7, 2024
Merged

feat: Labels on proposal #449

merged 3 commits into from
Oct 7, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Oct 6, 2024

Towards https://github.com/snapshot-labs/workflow/issues/143

Summary

  • Accepts labels on proposals

How to test

TODO:

  • Once approved, run following on testnet and prod DB
    ALTER TABLE proposals
    ADD COLUMN labels JSON DEFAULT NULL AFTER choices;

@ChaituVR ChaituVR requested a review from wa0x6e October 6, 2024 19:08
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ingestor.ts 50.00% 1 Missing ⚠️
src/writer/update-proposal.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit 269b952 into master Oct 7, 2024
2 checks passed
@ChaituVR ChaituVR deleted the labels-on-proposal branch October 7, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants