Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add endpoint to return snapit metadata #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 9, 2023

Pitch: https://www.notion.so/snapshotlabs/NFT-claimer-metadata-597d55cfba5a44d8906256be757d398d

Add endpoint to return the JSON metadata used by the NFT tokenURI

Todo later

  • Metadata should be a JSON file, uploaded to a static server

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (41f377f) 56.26% compared to head (6b15c93) 55.30%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   56.26%   55.30%   -0.97%     
==========================================
  Files          19       20       +1     
  Lines        1619     1658      +39     
  Branches      120      121       +1     
==========================================
+ Hits          911      917       +6     
- Misses        697      729      +32     
- Partials       11       12       +1     
Files Coverage Δ
src/helpers/snapshot.ts 91.35% <100.00%> (+0.28%) ⬆️
src/api.ts 0.00% <0.00%> (ø)
src/lib/nftClaimer/metadata.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant