-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IntegralDAO strategy [integral-dao] #1122
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use multiple contract-call strategies in your space instead of seperate strategy, you tried?
not convinient from our side, if that is the case |
Hi @sumomoliu you can also use multiple governor-alpha strategies, it is same, calls getCurrentVotes for each address |
sure |
confirmed that we may add addtional logics in the near future, so it is better to have this separate strategy, so we could keep updating it, |
Hi, @sumomoliu Can't merge it, as it is not unique https://github.com/snapshot-labs/snapshot-strategies#overview also this looks like combining three same strategies into one, we have a strategies limit for each space, if we accept this, then others will also point this pull request for combining more strategies into one. then the purpose of having a limit won't make sense |
so your suggestions are that I should direclty use governor-alpha? |
Yep :) Three of them, thanks for understanding |
.
Changes proposed in this pull request: