Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntegralDAO strategy [integral-dao] #1122

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sumomoliu
Copy link

@sumomoliu sumomoliu commented Apr 6, 2023

.

Changes proposed in this pull request:

  • Create new strategy [integral-dao] to calculate votes from staking amounts of Integral

@ChaituVR ChaituVR changed the title Add IntegralDAO strategy Add IntegralDAO strategy [integral-dao] Apr 10, 2023
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use multiple contract-call strategies in your space instead of seperate strategy, you tried?

src/strategies/integral-dao/index.ts Show resolved Hide resolved
@sumomoliu
Copy link
Author

I think we can use multiple contract-call strategies in your space instead of seperate strategy, you tried?

not convinient from our side, if that is the case

@ChaituVR
Copy link
Member

Hi @sumomoliu you can also use multiple governor-alpha strategies, it is same, calls getCurrentVotes for each address

@sumomoliu
Copy link
Author

Hi @sumomoliu you can also use multiple governor-alpha strategies, it is same, calls getCurrentVotes for each address

sure

@sumomoliu
Copy link
Author

Hi @sumomoliu you can also use multiple governor-alpha strategies, it is same, calls getCurrentVotes for each address

confirmed that we may add addtional logics in the near future, so it is better to have this separate strategy, so we could keep updating it,

@ChaituVR
Copy link
Member

Hi, @sumomoliu Can't merge it, as it is not unique https://github.com/snapshot-labs/snapshot-strategies#overview also this looks like combining three same strategies into one, we have a strategies limit for each space, if we accept this, then others will also point this pull request for combining more strategies into one. then the purpose of having a limit won't make sense

@sumomoliu
Copy link
Author

so your suggestions are that I should direclty use governor-alpha?

@ChaituVR
Copy link
Member

Yep :) Three of them, thanks for understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants