Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poap-unlock strategy [poap-unlock] #1209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

paulperegud
Copy link

Adds POAP-unlock voting strategy.

User has one vote if they have any POAPs and zero otherwise. If eventIds are specified, than only POAPs of particular event ids are taken into account.

User has one vote if they have any POAPs and zero otherwise.
If `eventIds` are specified, than only POAPs of particular event ids are taken
into account.
@ChaituVR ChaituVR changed the title Add poap-unlock strategy Add poap-unlock strategy [poap-unlock] Jul 5, 2023
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paulperegud I see this is same as poap strategy except the check for minimum, you can use our voting validation feature for this, https://docs.snapshot.org/user-guides/strategies/validation-strategies#voting-validation-in-space-settings

@ChaituVR
Copy link
Member

Closing this PR for now, feel free to reopen if needed :)

@ChaituVR ChaituVR closed this Jul 10, 2023
@vpabundance
Copy link

@ChaituVR I've been the one looking to set this up. Under the link provided, this appears to be for Proposal Validation. Can I ask how this would be applied to a strategy where users with 1, or multiple poaps have the same voting power?

@ChaituVR
Copy link
Member

Ah sorry, this one https://docs.snapshot.org/user-guides/strategies/validation-strategies#validation-strategy-example-basic

an I ask how this would be applied to a strategy where users with 1, or multiple poaps have the same voting power?
You can use it the way you want. after adding voting validation, use ticket strategy to get VP. so it will give one VP

@vpabundance
Copy link

Apologies for my lack of understanding here. "The Basic validation strategy allows you to use existing Voting Strategies configured for your space or define a custom setup to determine if a user is eligible to create a proposal or cast a vote. "

When I go to set this up, all I am seeing is the ability to add which poap events allow a user to be eligible to vote. When a user has both poaps in their wallet, they have x2 voting power.

Not seeing where we can limit that scenario to 1 under the link you provided.

Screenshot 2023-07-11 at 12 48 29 PM

@ChaituVR
Copy link
Member

So voting validations are just for yes or no, if validation return true, then using space voting strategies, setup a ticket strategy like here https://docs.snapshot.org/user-guides/spaces/settings#voting-strategies it will give 1 voting power to everyone who is validated with voting validation

@vpabundance
Copy link

Wouldn't this require then the use of passport?
Screenshot 2023-07-11 at 12 55 48 PM

@vpabundance
Copy link

Gitcoin is one of the 10 projects in this vote, and while we support them, it's not going to reflect well if voting requires the use of one of their products as this would reduce voters outside of their community.

@paulperegud
Copy link
Author

@ChaituVR This PR is something different from ticket option. Yes, both give user just 1 vote, but ticket option requires user to have gitcoin passport. Please reopen (I lack permissions to do that).

@ChaituVR ChaituVR reopened this Jul 12, 2023
@ChaituVR
Copy link
Member

Hey guys we don't require gitcoin validation anymore, you can use basic validation too. in basic validation, you can use poap strategy and set the minimum score to your desired number of tokens required to vote, and the ticket strategy to give 1 voting power

Sorry those docs are outdated. @zuz could you update that plz :) #1209 (comment)

@vpabundance
Copy link

Having trouble getting what you are suggesting to work. Here is what I have under: valdation>basic:

{
"symbol": "POAP",
"eventIds": [
"128253",
"128044"
]
}

And then additionally ticket with voting power of 1.

This still returns a voting power of 2 should a wallet have 2 poaps.

Are you able to look at the setup on https://snapshot.org/#/octantapp.eth/settings and see what I am missing here?
Thank you for any insight!
Screenshot 2023-07-12 at 3 30 04 PM
Screenshot 2023-07-12 at 3 30 11 PM

@zzuziak
Copy link
Contributor

zzuziak commented Jul 14, 2023

Hey @vpabundance, the setup seems right, and the ticket strategy always gives only 1 VP. Did you check it on a new proposal after updating the settings? Keep in mind that the update in settings affects only new strategies.

@vpabundance
Copy link

Thank you so much to everyone here who helped, I successfully created and tested the voting. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants