Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[delegate-registry-v2] Add optional v1 support #1345

Closed
wants to merge 2 commits into from
Closed

[delegate-registry-v2] Add optional v1 support #1345

wants to merge 2 commits into from

Conversation

asgeir-s
Copy link
Contributor

Adds optional support for "delegate registry v1" delegations in the "delegate registry v2" strategy.

ChaituVR
ChaituVR requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also PR should be coming from gnosis github as they are the author, can fork this from there? or better to create a new strategy

src/strategies/delegate-registry-v2/index.ts Show resolved Hide resolved
@ChaituVR
Copy link
Member

I see you are original author of the strategy

@ChaituVR
Copy link
Member

@manboy-eth Test cases are failing can take a look?
image

@asgeir-s
Copy link
Contributor Author

Closing since I opened a PR from Gnosis: #1353

I will also address the test error in that PR

@asgeir-s asgeir-s closed this Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR requested changes

Assignees
No one assigned
Labels
strategy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asgeir-s @ChaituVR