ENS Reverse Record #264
Merged
ENS Reverse Record #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonustrack
reviewed
Mar 19, 2021
bonustrack
reviewed
Mar 19, 2021
…/snapshot into ens-reverse-record
…nto ens-reverse-record
|
@ChaituVR I think we will need to query both ENS subgraph to get the list of domain and the contract with getNames to get the prefered one, otherwise we would miss too much name. |
|
@bonustrack yaaa.. i agree 👍 will add back subgraph with getnames contract as prefered one |
…nto ens-reverse-record
…/snapshot into ens-reverse-record
|
@bonustrack Added back subgraph and reverse record as preferred one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260