-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Boost #4437
feat: Boost #4437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested.
- Reviewed the entire pull request up to 27be088
- Looked at
2019
lines of code in24
files - Took 3 minutes and 31 seconds to review
More info
- Skipped
80
files when reviewing. - Skipped posting
3
additional comments because they didn't meet confidence threshold of50%
.
1. src/composables/useAccount.ts:30
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
The variablebroviderUrl
is not defined. Please ensure that it is correctly defined and initialized. - Reasoning:
TheuseAccount
composable function is using a variablebroviderUrl
which is not defined anywhere in the function or imported from elsewhere. This could lead to a reference error at runtime.
2. src/composables/useProposalVotes.ts:92
:
- Assessed confidence :
80%
- Grade:
0%
- Comment:
The conditionloadBy > votes.value.length
seems to be incorrect becauseloadBy
is a constant value and does not depend on the length ofvotes.value
. Please review this condition. - Reasoning:
TheuseProposalVotes
function has a condition that checks ifloadBy
is greater than the length ofvotes.value
. This condition seems to be incorrect becauseloadBy
is a constant value and does not depend on the length ofvotes.value
. This could lead to logical errors.
3. src/composables/useAccount.ts:8
:
- Assessed confidence :
100%
- Grade:
0%
- Comment:
It seems like thesnapshot
module is not imported in this file. This could lead to a reference error at runtime. Please add the necessary import statement. - Reasoning:
ThegetERC20Account
function is using a variablemulti
which is an instance ofsnapshot.utils.Multicaller
. However, thesnapshot
module is not imported in this file. This could lead to a reference error at runtime.
Workflow ID: wflow_pBFq0eIBIRfCAVzN
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. We'll respond in a few minutes. Learn more here.
provider: any, | ||
account: string, | ||
token: string, | ||
chainId: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the useWeb3
composable is not imported in this file. This could lead to a reference error at runtime. Please add the necessary import statement.
@@ -0,0 +1,18 @@ | |||
import { BOOST_WHITELIST_SETTINGS } from '@/helpers/boost'; | |||
|
|||
export function useBoost({ spaceId }: { spaceId: string }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the useApp
composable is not imported in this file. This could lead to a reference error at runtime. Please add the necessary import statement.
Summary
Summary:
This PR introduces a new 'Boost' feature to the Snapshot project, involving the creation, management, and interaction with 'boosts' associated with proposals, along with updates to the project's validation and voting mechanisms.
Key points:
Generated with ❤️ by ellipsis.dev