Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Boost #4437

Merged
merged 448 commits into from
Mar 8, 2024
Merged

feat: Boost #4437

merged 448 commits into from
Mar 8, 2024

Conversation

samuveth
Copy link
Contributor

@samuveth samuveth commented Dec 8, 2023

Summary


Ellipsis 🚀 This PR description was created by Ellipsis for commit 27be088.

Summary:

This PR introduces a new 'Boost' feature to the Snapshot project, involving the creation, management, and interaction with 'boosts' associated with proposals, along with updates to the project's validation and voting mechanisms.

Key points:

  • Added new routes and components for the 'Boost' feature.
  • Created new helper functions and updated existing ones to support the 'Boost' feature.
  • Updated project constants and utilities to accommodate the new feature.
  • Made changes to the project's validation and voting mechanisms.
  • Introduced the concept of 'boosts' associated with proposals.

Generated with ❤️ by ellipsis.dev

@samuveth samuveth marked this pull request as ready for review March 8, 2024 13:08
@samuveth samuveth merged commit b554b60 into master Mar 8, 2024
4 of 5 checks passed
@samuveth samuveth deleted the samuv/boost branch March 8, 2024 13:08
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Reviewed the entire pull request up to 27be088
  • Looked at 2019 lines of code in 24 files
  • Took 3 minutes and 31 seconds to review
More info
  • Skipped 80 files when reviewing.
  • Skipped posting 3 additional comments because they didn't meet confidence threshold of 50%.
1. src/composables/useAccount.ts:30:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    The variable broviderUrl is not defined. Please ensure that it is correctly defined and initialized.
  • Reasoning:
    The useAccount composable function is using a variable broviderUrl which is not defined anywhere in the function or imported from elsewhere. This could lead to a reference error at runtime.
2. src/composables/useProposalVotes.ts:92:
  • Assessed confidence : 80%
  • Grade: 0%
  • Comment:
    The condition loadBy > votes.value.length seems to be incorrect because loadBy is a constant value and does not depend on the length of votes.value. Please review this condition.
  • Reasoning:
    The useProposalVotes function has a condition that checks if loadBy is greater than the length of votes.value. This condition seems to be incorrect because loadBy is a constant value and does not depend on the length of votes.value. This could lead to logical errors.
3. src/composables/useAccount.ts:8:
  • Assessed confidence : 100%
  • Grade: 0%
  • Comment:
    It seems like the snapshot module is not imported in this file. This could lead to a reference error at runtime. Please add the necessary import statement.
  • Reasoning:
    The getERC20Account function is using a variable multi which is an instance of snapshot.utils.Multicaller. However, the snapshot module is not imported in this file. This could lead to a reference error at runtime.

Workflow ID: wflow_pBFq0eIBIRfCAVzN


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

provider: any,
account: string,
token: string,
chainId: string,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the useWeb3 composable is not imported in this file. This could lead to a reference error at runtime. Please add the necessary import statement.

@@ -0,0 +1,18 @@
import { BOOST_WHITELIST_SETTINGS } from '@/helpers/boost';

export function useBoost({ spaceId }: { spaceId: string }) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the useApp composable is not imported in this file. This could lead to a reference error at runtime. Please add the necessary import statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants