Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: osnap snapshot tx builder bug #4576

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

daywiss
Copy link
Contributor

@daywiss daywiss commented Feb 22, 2024

Summary

There was a bug in the transaction builder where the app would load all tokens you have balances for (your safe on a certain network), then when you switch safes, that list of tokens would not update. We also were not including the balance of the native token in the token chooser modal. This was because the balance pulled from gnosis, if that balance was for a native token it would be stripped out by the app, then later we just hardcoded in the native asset for the chain as an option, but without the balance info.

This PR rectifies some of the state management so that we reload token balances and token lists when we switch safes.
It also ensures we keep the safe's balance for native tokens so we can display this data to the user.

image

How to test

  1. go to an osnap plugin enabled space
  2. create a proposal, in the transactiion builder select send tokens
  3. see that safe assets show up in the assets list

@daywiss daywiss force-pushed the gerhard/uma-2395-osnap-snapshot-tx-builder-bug branch from 2c8ccb7 to 7a490bb Compare February 22, 2024 18:56
@samuveth samuveth merged commit ade4c22 into master Feb 23, 2024
5 checks passed
@samuveth samuveth deleted the gerhard/uma-2395-osnap-snapshot-tx-builder-bug branch February 23, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants