Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Whitelist with-delegation strategies and use checksum addresses #4933

Merged
merged 2 commits into from
Nov 16, 2024
Merged

fix: Whitelist with-delegation strategies and use checksum addresses #4933

merged 2 commits into from
Nov 16, 2024

Conversation

ChaituVR
Copy link
Member

Summary

Delegation is broken if space is using with-delegation strategies, Because:

  1. with-delegation strategies are not whitelisted
  2. these strategies return checksummed addresses from score-api

How to test

  1. Go to https://snapshot.org/#/delegate/moxie.eth
  2. You should see top delegates

wa0x6e
wa0x6e approved these changes Nov 16, 2024
View reviewed changes
Copy link
Collaborator

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 45becbf into master Nov 16, 2024
7 checks passed
@ChaituVR ChaituVR deleted the fix-delegate-view branch November 16, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e