Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use re-exported tungstenite types so its easier to copy examples and … #275

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

alexgeek
Copy link

…not depend directly on tungstenite.

(I ran into the same confusion as in: #141)

@daniel-abramov
Copy link
Member

Neat :) Would you mind checking the CI errors? It seems like the formatting is a bit off.

@agalakhov
Copy link
Member

JFYI: we already reexport Tungstenite as a whole:

pub use tungstenite;

@alexgeek
Copy link
Author

JFYI: we already reexport Tungstenite as a whole:

pub use tungstenite;

Should I have done something differently in the PR because of that?

@agalakhov
Copy link
Member

No, everything looks fine. This only means that there is no need to depend directly of tungstenite even if using non-reexported types.

@daniel-abramov daniel-abramov merged commit 1c97eb7 into snapview:master Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants