Sync no-web branch with upstream #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New melos target to run code-gen and CI check to verify that there is no difference. Co-authored-by: Alexander Thiele <AlexanderThiele@users.noreply.github.com>
queryRenderedFeaturesInRect doesnt support string feature ids on web. This fixes this issue. Co-authored-by: Alexander Thiele <AlexanderThiele@users.noreply.github.com>
with the recent upgrade to ios 6.12.1 a memory got introduced from the c++ native side. This upgrades the ios version to 6.12.3 which has a fix for this issue. Co-authored-by: Alexander Thiele <AlexanderThiele@users.noreply.github.com>
Hey! I've added a GPS example page with 2 buttons. The first button enabled GPS and navigates to the current position, and the second button switches from the default LocationEnginePlatforms settings to a Setting with LocationPriority.highAccuracy (on Android) The location behavior is different on android. Whenever you keep the default setting, maplibre does not update the location. (left you can see an active navigation - right the current position in Maplibre - it's clearly off)  whenever i activate high accuracy, the position actually updates and is following the user.  --------- Co-authored-by: alexanderthiele <alexander.thiele@ocell.io>
- Android 11.9.0 - Android NDK update (maplibre-native now uses `28.1.13356709`) - iOS 6.14.0 - Web compilation fix --------- Co-authored-by: Alexander Thiele <AlexanderThiele@users.noreply.github.com>
from MRs: maplibre#577 maplibre#576 Co-authored-by: alexanderthiele <alexander.thiele@ocell.io>
This PR addresses long-standing issues with inconsistent style loading behavior between the native and web platforms, both in this repo and the original library. On the web, style updates are applied incrementally—only the parts that have changed are updated. In contrast, the native side performs full style replacements. This mismatch has led to divergent runtime behavior and visual inconsistencies between the platforms. Compounding this, the web implementation inconsistently triggers the onStyleLoaded callback. This can lead to scenarios where outdated style components remain active even after a new style is supposed to be fully loaded. As a workaround, this PR adds a polling mechanism that verifies the style has actually finished loading before notifying the Flutter side via the callback. --------- Co-authored-by: Alexander Thiele <AlexanderThiele@users.noreply.github.com>
This PR addresses several crashes that occurred when attempting to add layers and sources that already exist. The fix introduces appropriate guard statements and ensures that errors are correctly propagated to the Flutter layer when necessary. Previously, such issues would result in a crash. With this change, they now raise a platform exception instead. --------- Co-authored-by: Alexander Thiele <AlexanderThiele@users.noreply.github.com>
this will fix maplibre#571 this commit will set the locationEngine on enableLocationComponent. the problem was, that when calling `setLocationEngineProperties`, `locationComponent` is always null. This will properly add the engine whenever the location component is set. Co-authored-by: alexanderthiele <alexander.thiele@ocell.io>
# Conflicts: # maplibre_gl_web/lib/maplibre_gl_web.dart # maplibre_gl_web/lib/src/maplibre_web_gl_platform.dart # maplibre_gl_web/lib/src/ui/map.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing our no-web branch with the upstream to stay aligned with the latest development and fixes.