Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console command to disable SAML logins #16521

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jerm
Copy link
Collaborator

@jerm jerm commented Mar 18, 2025

If a Snipe-IT sire has SAML enabled, and the SAML config is sufficiently
borked, login and logout pages will 500. That's probably
something that should be examined, but in the meantime, it'd be handy to
not have to manually edit the database to turn off SAML in order to
recover the site.

In this commit, I'm creating a saml-disable console command. And by
create, i mean i'm copypasta-ing the existing ldap-disable command.

If a Snipe-IT sire has SAML enabled, and the SAML config is sufficiently
borked, the site will fail to even load the login page. That's probably
something that should be examined, but in the meantime, it'd be handy to
not have to manually edit the database to turn off SAML.

In this commit, I'm creating a saml-disable console command. And by
create, i mean i'm copypasta-ing the existing ldap-disable command.
Copy link

what-the-diff bot commented Mar 18, 2025

PR Summary

  • Introduction of a New Comand to Disable SAML Settings
    A new command has been added to the software. This command allows you to turn off SAML settings within the application, essentially disabling a method used for exchanging authentication and authorization data.

  • Definition of Command Signature and Description
    The new command comes with an appropriate signature, which is snipeit:saml-disable. This unique signature helps to identify the command and its function. It is accompanied by a description that gives additional details about what it does.

  • Inclusion of a Confirmation Prompt
    To guard against unintended outcomes, a confirmation prompt has been implemented. This feature will prevent the accidental disabling of SAML support by asking users for confirmation before proceeding with the command.

  • Command Acting on User's Confirmation
    Upon receiving a positive confirmation from the user, the command executes and updates the settings to disable SAML. It then gives feedback, informing the user of the success or failure of the operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant