Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active table tab and double scroll bar under locations #16529

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Mar 18, 2025

This fixes the active tab when viewing locations. if there are users and the current user has permission to view users the users tab will be first active, otherwise it will default to the assets tab.

for the double scroll bar, I removed <div class="table table-responsive"> around the tables which load the table class already. This solves the double scroll bars on the tables. Not sure if this just old code..but functionality is as intended now.

Repositioned the users table code above the assets table code for symmetry with the tabs' order.
[SC-28710]
#16523

Before image provided by @swift2512
image

After:
image

Copy link

what-the-diff bot commented Mar 18, 2025

PR Summary

  • New User Management Section

    • With this PR, our system now has a dedicated section for managing users. Please note, this section can only be accessed by those users who have the necessary permissions. This section will include a table listing user details with numerous features like pagination, search, and data export.
  • Improved Asset Management Structure

    • The design structure for managing assets has been revamped. There has been a removal of redundant elements that were hindering optimal site responsiveness. Also, the structure of the asset and user tables has been simplified.
  • Enhanced Visibility Controls for User and Asset sections

    • The system can now switch visibility between 'users' and 'assets' tabs based on user count. This will make the navigation experience smoother and more dynamic.
  • Simplified Table Structure

    • The table structure for various elements in different sections has been streamlined. This is accomplished by eliminating unnecessary containers which subsequently simplify the overall layout of tables.

@Godmartinz Godmartinz changed the title Fix active table tab and double scroll bar under location tabs Fix active table tab and double scroll bar under locations Mar 18, 2025
Copy link
Collaborator

@spencerrlongg spencerrlongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! Pulled it down and see the issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants