Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXED: Adding Total to Consumable View Page #16537

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Mar 19, 2025

This adds Total to the Consumable View page

OLD:
Screenshot 2025-03-19 at 3 34 47 PM

NEW:
Screenshot 2025-03-19 at 3 34 32 PM

Copy link

what-the-diff bot commented Mar 19, 2025

PR Summary

  • Added Quantity Display for Consumables
    This update adds a new section in our application where you can see the total number of any item (a consumable) if it exists. It will show a label and the corresponding quantity, making it easier for users to track their resources.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but I wonder if we match the order from the index? The order in this PR, Total Remaining Min, makes the most sense to me and maybe we should update the index to follow that order as well?

image

Approving this code-wise but @snipe might have a some input to add.

@akemidx
Copy link
Collaborator Author

akemidx commented Mar 20, 2025

oh, yea. I agree actually. I think I placed it just where it made sense, and it skipped my mind to check if the order matched.

Tho it looks like the order was mismatched to begin with. So, yea, a chat about what order we wanna do probably is in order.

@akemidx
Copy link
Collaborator Author

akemidx commented Mar 20, 2025

order change
Screenshot 2025-03-20 at 2 17 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants