Skip to content

Fix rare invalid output in float to string conversion #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

cschreib
Copy link
Member

Fixes #193

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (fe9249d) to head (57c90b4).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   94.17%   94.16%   -0.02%     
==========================================
  Files          30       30              
  Lines        1750     1747       -3     
==========================================
- Hits         1648     1645       -3     
  Misses        102      102              
Files with missing lines Coverage Δ
include/snitch/snitch_append.hpp 96.07% <100.00%> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9249d...57c90b4. Read the comment docs.

@cschreib cschreib merged commit 675885f into main Nov 17, 2024
43 checks passed
@cschreib cschreib deleted the cschreib/float-fix branch November 17, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double precision floating point number contains null character when printed
1 participant