Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1569290 Make Azure headers case insensitive #1238

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Nov 5, 2024

Description

SNOW-1569290 Azure client treated headers as case sensitive before, which causes fails when downloading files uploaded by other drivers.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner November 5, 2024 09:26
azure_storage_client.go Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (27e76c9) to head (a6bf5f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
- Coverage   82.59%   82.58%   -0.01%     
==========================================
  Files          55       55              
  Lines       13315    13321       +6     
==========================================
+ Hits        10997    11001       +4     
- Misses       2318     2320       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus enabled auto-merge (squash) November 6, 2024 10:08
@sfc-gh-pfus sfc-gh-pfus merged commit ae12fff into master Nov 6, 2024
39 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1569290-headers-lower branch November 6, 2024 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants