Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1569290 Use 12 bytes for IV in gcm #1239

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

sfc-gh-pfus
Copy link
Collaborator

Description

SNOW-1569290 Fixes to use 12 bytes for GCM encryption.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner November 5, 2024 09:44
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.57%. Comparing base (27e76c9) to head (263b051).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   82.59%   82.57%   -0.02%     
==========================================
  Files          55       55              
  Lines       13315    13315              
==========================================
- Hits        10997    10995       -2     
- Misses       2318     2320       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sfc-gh-mkubik sfc-gh-mkubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit 4f3ec9c into master Nov 6, 2024
38 of 39 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-1569290-gcm-iv-12b branch November 6, 2024 07:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants