Skip to content

SNOW-2018652 add automated tests for Soteria #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Conversation

sfc-gh-akolodziejczyk
Copy link
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented Jun 2, 2025

Description

SNOW-2018652

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review June 2, 2025 08:56
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner June 2, 2025 08:56
Copy link
Contributor

@sfc-gh-pcyrek sfc-gh-pcyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.54%. Comparing base (c45a56b) to head (747edd5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   89.57%   89.54%   -0.03%     
==========================================
  Files          76       76              
  Lines        7558     7558              
==========================================
- Hits         6770     6768       -2     
- Misses        788      790       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sfc-gh-pmotacki sfc-gh-pmotacki merged commit a9174fb into master Jun 3, 2025
48 of 49 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-2018652-2 branch June 3, 2025 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants