Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-925990 add logging for mapping resultset columns #715

Merged
merged 10 commits into from
Jan 4, 2024

Conversation

sfc-gh-dszmolka
Copy link
Collaborator

Description

  • This is a very small logging change required earlier by Support, for having some insight into the event of mapping resultset columns.
  • Requirements and performance test on tw676.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

* requirements and performance test on tw676
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46c2fa8) 87.39% compared to head (75c35d9) 87.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   87.39%   87.13%   -0.26%     
==========================================
  Files          61       61              
  Lines        5791     5793       +2     
==========================================
- Hits         5061     5048      -13     
- Misses        730      745      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka marked this pull request as ready for review December 4, 2023 09:46
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team as a code owner December 4, 2023 09:46
lib/connection/result/result.js Outdated Show resolved Hide resolved
lib/connection/result/result.js Show resolved Hide resolved
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dszmolka sfc-gh-dszmolka merged commit 29c12d1 into master Jan 4, 2024
47 of 48 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the SNOW-925990-log-column-mapping-progress branch January 4, 2024 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants