-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-843716: Cryptography library cleanup #1605
Comments
Thanks for this @geofft. |
If you can get rid of urllib3.contrib.pyopenssl this way, that should also solve #1586 |
The code to use cryptography (which uses OpenSSL) already existed, but it just wasn't being used by default. Since cryptography is currently a mandatory dependency, we may as well use it all the time. Partially resolves snowflakedb#1605/SNOW-843716.
Getting rid of Wondering if #1616 can be expedited as it will resolve our pain point? @sfc-gh-spanaite |
The code to use cryptography (which uses OpenSSL) already existed, but it just wasn't being used by default. Since cryptography is currently a mandatory dependency, we may as well use it all the time. Partially resolves snowflakedb#1605/SNOW-843716.
oscrypto has had this very serious bug since August. The fix was merged. However, the fix was never released to pypi. An issue was raised to request a release. However, there has been no response. The repo has had almost no commits since then. The repo does not appear to be well supported. It could be that oscrypto is a case of an open source library that just does not have enough maintainers to make it reliable. |
This is also affecting |
Debian 12 Bookworm just busted for us too - very hard to work around this issue in the various libraries we use. Would be great to remove dependency on oscrypto. I have mentioned this in a separate bug, which feels more urgent |
I managed to get my Debian 12 docker containers working by adding |
thanks for all the feedback, we're going to remove the dependency on oscrpyto and pycryptodomex in our next connector release and we will do a release for snowsql accordingly. I have created an announcement issue: #1781 |
we have released v3.4.0 removing oscrypto and pycryptodomex, thank you! |
What is the current behavior?
Hi! It looks like the connector depends on five cryptography-related packages,
asn1crypto
,cryptography
,oscrypto
,pyOpenSSL
, andpycryptodome
.Would there be interest in consolidating these as far as possible? I think most of this can be consolidated onto just the cryptography library. I'd be happy to contribute a pull request, just wanted to check with you all first. The one I'm least sure about is
asn1crypto
, but it looks like that one's being used for OCSP support, whichcryptography
has high-level functions for. From a quick look, everything else seems like stuff I'm pretty surecryptography
can handle.What is the desired behavior?
Ideally, the connector should depend on a single, well-maintained cryptography library.
How would this improve
snowflake-connector-python
?This would reduce maintenance overhead and security risk.
References and other background
No response
The text was updated successfully, but these errors were encountered: