Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependencies on Cryptodome and oscrypto #1616

Closed
wants to merge 2 commits into from
Closed

Remove dependencies on Cryptodome and oscrypto #1616

wants to merge 2 commits into from

Conversation

geofft
Copy link

@geofft geofft commented Jun 23, 2023 •
edited
Loading

The code to use cryptography (which uses OpenSSL) already existed, but it just wasn't being used by default. Since cryptography is currently a mandatory dependency, we may as well use it all the time.

Partially resolves #1605/SNOW-843716.

@github-actions
Copy link

github-actions bot commented Jun 23, 2023 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ (sfc-gh-sfan)[https://github.com/sfc-gh-sfan]
❌ @geofft
You can retrigger this bot by commenting recheck in this Pull Request

@geofft
Copy link
Author

geofft commented Jun 23, 2023 •
edited
Loading

  1. Can you please document the need for CLAs in CONTRIBUTING.md? I checked before volunteering to contribute. Getting a CLA approved by legal is an internally onerous process and I prefer not to contribute to repositories that require it. (If you require an individual CLA, then it requires me to hire counsel on my own to review the CLA, which I will not do.) The Apache license already guarantees appropriate licensing of the contribution in section 5.
  2. The CLA link gives me a 404, so I am unable to do anything with it.

sfc-gh-sfan
sfc-gh-sfan approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-sfan sfc-gh-sfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpark-hrp
Copy link

kpark-hrp commented Sep 26, 2023 •
edited
Loading

@geofft @sfc-gh-sfan Are there plans to merge this in any time soon? Getting rid of oscrypto would be very helpful

@kpark-hrp kpark-hrp mentioned this pull request Sep 26, 2023
Closed
@kpark-hrp
Copy link

@sfc-gh-sfan It looks like it's failing on linters

@sfc-gh-sfan
Copy link
Contributor

@geofft Can you fix the linter error?

@kpark-hrp
Copy link

@geofft Can you fix the linter error?

Just a reminder 😃

@geofft
Remove dependencies on Cryptodome and oscrypto
9f30872 
The code to use cryptography (which uses OpenSSL) already existed, but
it just wasn't being used by default. Since cryptography is currently a
mandatory dependency, we may as well use it all the time.

Partially resolves snowflakedb#1605/SNOW-843716.
@sfc-gh-sfan
Copy link
Contributor

test PR in #1752

@sfc-gh-sfan
Copy link
Contributor

@geofft Can you sign the CLA (link: https://github.com/snowflakedb/CLA/blob/main/README.md)?

@kpark-hrp
Copy link

Hey @geofft, can this be driven to completion?

@kpark-hrp
Copy link

@sfc-gh-sfan At this point, is it possible for Snowflake to commandeer this PR?

@sfc-gh-sfan
Copy link
Contributor

Done in #1779

@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kpark-hrp kpark-hrp kpark-hrp approved these changes

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-843716: Cryptography library cleanup
3 participants
@geofft @kpark-hrp @sfc-gh-sfan