-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-926289 updating vendored libraries #1793
SNOW-926289 updating vendored libraries #1793
Conversation
We might need to still pin |
@sfc-gh-mkeller Please explain, because I just closed our incident with your intention to drop the urllib pin. As you mention urllib is a transient dependency of snowflake-connector-python. I understand that requests is a direct dependency for the OCSP code and cannot be removed (but unpinned). Why are you therefore pinning urllib < 2? Is it only for asserting that a normal pip install snowflake-connector-python will not run into problems on Centos 7? Why don't you let the users pin urllib in their environment by themselves? The urllib documentation even mentions pinning to urllib < 2 in these cases. @pquentin Could you please comment on the best practices here? |
The best practice is definitely to let users pin in their environments. https://hynek.me/articles/semver-will-not-save-you/ covers that and mentions urllib3<2 even if it was published before we released 2.0. That said, if you have many customers that rely on CentOS 7 or Amazon Linux 2 you can do like botocore and only allow urllib3 2.0 on Python 3.10 and above, as those versions of Python do not even compile without OpenSSL 1.1.1+, per https://peps.python.org/pep-0644/. |
@timostrunk It's because of our FIPS mode. If we allow |
Sorry folks @timostrunk @timostrunk @sfc-gh-mkeller , I needed to merge this PR ASAP to unblock a requested security fix release. We will continue to work on removing the pin for #1743, please feel free to continue the conversation there. |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-926289
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Bumping the vendored
requests
andurllib3
libraries to the newest versions (ignoring v2 releases ofurllib3
).I also remove the transient
urllib3
dependency of the vendored` requests (discussed in SNOW-926289: Why is urllib3 both vendored and marked as a dependency? #1743 )