Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer TLD for China based on region in account #2040

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

sfc-gh-vvenugopal
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sfc-gh-aling
Copy link
Collaborator

LGTM, thanks for the PR.
could you help update the changelog https://github.com/snowflakedb/snowflake-connector-python/blob/main/DESCRIPTION.md

and sign the CLA as per the instruction in bot's comment: #2040 (comment)

@sfc-gh-vvenugopal
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-vvenugopal
Copy link
Contributor Author

recheck

@sfc-gh-vvenugopal sfc-gh-vvenugopal enabled auto-merge (squash) August 30, 2024 21:57
@sfc-gh-vvenugopal sfc-gh-vvenugopal merged commit 075b96a into main Aug 30, 2024
88 of 93 checks passed
@sfc-gh-vvenugopal sfc-gh-vvenugopal deleted the viswa/fix-cn branch August 30, 2024 22:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants