Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1559272: Document differences b/w query result APIs #2055

Merged
merged 1 commit into from
Sep 12, 2024
Merged

SNOW-1559272: Document differences b/w query result APIs #2055

merged 1 commit into from
Sep 12, 2024

Conversation

sfc-gh-aalam
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1559272: get_results_from_sfqid(query_id) vs query_result(query_id) #2009

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Update documentation to show the differences between query_result and get_results_from_sfqid APIs.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-aalam sfc-gh-aalam added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Sep 12, 2024
@sfc-gh-aalam sfc-gh-aalam merged commit d165bd3 into main Sep 12, 2024
98 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-1559272-improve-documentation branch September 12, 2024 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-1559272: get_results_from_sfqid(query_id) vs query_result(query_id)
2 participants
@sfc-gh-aalam @sfc-gh-jrose