Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1778088 azure md5 #2102

Merged
merged 7 commits into from
Nov 7, 2024
Merged

SNOW-1778088 azure md5 #2102

merged 7 commits into from
Nov 7, 2024

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1778088

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    In this PR I fix a bug where files uploaded to Azure blob storage in pieces would be missing their MD5 hashes. Azure blob storage calculates these for small files automatically, but we need to do this manually for large files.

  4. (Optional) PR for stored-proc connector:
    Unaffected.

@sfc-gh-mkeller sfc-gh-mkeller added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Nov 6, 2024
@sfc-gh-mkeller sfc-gh-mkeller self-assigned this Nov 6, 2024
@sfc-gh-mkeller sfc-gh-mkeller merged commit 1e4d456 into main Nov 7, 2024
94 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-1778088-azure_md5 branch November 7, 2024 18:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants