Skip to content

Commit

Permalink
SNOW-1734196: fix flaky test (#2440)
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-aling authored Oct 14, 2024
1 parent 25dd160 commit 1f19621
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 3 additions & 1 deletion tests/integ/scala/test_update_delete_merge_suite.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import pytest

from snowflake.connector.options import installed_pandas, pandas as pd
from snowflake.connector.options import installed_pandas
from snowflake.snowpark import (
DeleteResult,
MergeResult,
Expand Down Expand Up @@ -678,6 +678,8 @@ def test_merge_multi_operation(session):
)
def test_snow_1694649_repro_merge_with_equal_null(session):
# Force temp table
import pandas as pd

df1 = session.create_dataframe(pd.DataFrame({"A": [0, 1], "B": ["a", "b"]}))
df2 = session.create_dataframe(pd.DataFrame({"A": [0, 1], "B": ["a", "c"]}))

Expand Down
5 changes: 4 additions & 1 deletion tests/integ/test_udf.py
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,10 @@ def only_type_hint(s: str) -> str:
only_type_hint_udf = session.udf.register(d["only_type_hint"])

# assert that no warnings are raised here
assert len(caplog.records) == 0
# SNOW-1734254 for suppressing opentelemetry warning log
assert len(caplog.records) == 0 or [
all("opentelemetry" in str(record) for record in caplog.records)
]


@pytest.mark.xfail(
Expand Down

0 comments on commit 1f19621

Please sign in to comment.