Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1556590] Enable test_sql with new compilation stage #2207

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[SNOW-1556590] Enable test_sql with new compilation stage #2207

merged 1 commit into from
Sep 3, 2024

Conversation

sfc-gh-yzou
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

SNOW-1556590

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  2. Please describe how your code solves the related issue.

The test was failing when sql simplification is off, this is fixed with the new query compilation stage, re-enable the test

@sfc-gh-yzou sfc-gh-yzou requested a review from a team as a code owner August 31, 2024 01:20
@sfc-gh-yzou
Copy link
Collaborator Author

https://github.com/snowflakedb/snowpark-python/actions/runs/10641224052

@sfc-gh-yzou sfc-gh-yzou added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 31, 2024
@sfc-gh-yzou sfc-gh-yzou merged commit b68d75f into main Sep 3, 2024
89 of 90 checks passed
@sfc-gh-yzou sfc-gh-yzou deleted the yzou-SNOW-1556590-enable-test branch September 3, 2024 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-yzou @sfc-gh-jdu @sfc-gh-aalam