Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1556590] Enable test_sql with new compilation stage #2207

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[SNOW-1556590] Enable test_sql with new compilation stage #2207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/integ/test_cte.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,10 +423,6 @@ def test_table(session):
assert count_number_of_ctes(df_result.queries["queries"][-1]) == 1


@pytest.mark.skipif(
"config.getoption('disable_sql_simplifier', default=False)",
reason="TODO SNOW-1556590: Re-enable test_sql in test_cte.py when sql simplifier is disabled once new CTE implementation is completed",
)
@pytest.mark.parametrize(
"query",
[
Expand All @@ -435,6 +431,11 @@ def test_table(session):
],
)
def test_sql(session, query):
if not session._query_compilation_stage_enabled:
pytest.skip(
"CTE query generation without the new query generation doesn't work correctly"
)

df = session.sql(query).filter(lit(True))
df_result = df.union_all(df).select("*")
check_result(session, df_result, expect_cte_optimized=True)
Expand Down
Loading