SNOW-1672691: Remove snowflake/snowpark/modin/pandas folder #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-joshi
added
NO-CHANGELOG-UPDATES
sfc-gh-joshi
requested review from
sfc-gh-dpetersohn,
sfc-gh-lmukhopadhyay,
sfc-gh-aling,
sfc-gh-yuwang and
sfc-gh-aalam
|
(triggered Snowpark Python review because of changes to |
sfc-gh-joshi
force-pushed
the
joshi/rip-pandas
branch
from
e231c7f
to
56fc701
Compare
sfc-gh-azhan
approved these changes
Sep 26, 2024
sfc-gh-jjiao
approved these changes
Sep 26, 2024
sfc-gh-jrose
approved these changes
Sep 26, 2024
sfc-gh-yzou
reviewed
Sep 26, 2024
| # base overrides occur before subclass overrides in case subclasses override a base method | ||
| import snowflake.snowpark.modin.plugin.extensions.base_extensions # isort: skip # noqa: E402,F401 | ||
| import snowflake.snowpark.modin.plugin.extensions.base_overrides # isort: skip # noqa: E402,F401 | ||
| import snowflake.snowpark.modin.plugin.extensions.dataframe_extensions # isort: skip # noqa: E402,F401 |
There was a problem hiding this comment.
@sfc-gh-joshi where did groupby go? i don't see groupby here
There was a problem hiding this comment.
We don't need to explicitly import groupby/resample/window/indexing overrides because they don't trigger any modin.api.extensions.register_*_accessor calls. Instead, we override the call to DataFrame.groupby(), DataFrame.rolling, and similar methods to just return a Snowpark pandas DataFrameGroupBy/Window object defined in groupby_overrides.py/window_overrides.py.
sfc-gh-yzou
approved these changes
Sep 26, 2024
sfc-gh-joshi
force-pushed
the
joshi/rip-pandas
branch
from
56fc701
to
7390b54
Compare
|
Good riddance to snowflake/snowpark/modin/pandas ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1672691
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR removes the snowflake/snowpark/modin/pandas folder. Remaining docstring paths have been modified appropriately, and necessary initialization code has moved to snowflake/snowpark/modin/plugin/init.py.
Previously, we exposed methods from
general_overridesandio_overridesas direct exports from thesnowflake.snowpark.modin.pandasthat were then mirrored into themodin.pandasnamespace. Now, we directly callmodin.pandas.api.extensions.register_pd_accessorto populatemodin.pandas.