-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1672691: Remove snowflake/snowpark/modin/pandas folder #2345
Conversation
(triggered Snowpark Python review because of changes to |
e231c7f
to
56fc701
Compare
# base overrides occur before subclass overrides in case subclasses override a base method | ||
import snowflake.snowpark.modin.plugin.extensions.base_extensions # isort: skip # noqa: E402,F401 | ||
import snowflake.snowpark.modin.plugin.extensions.base_overrides # isort: skip # noqa: E402,F401 | ||
import snowflake.snowpark.modin.plugin.extensions.dataframe_extensions # isort: skip # noqa: E402,F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-joshi where did groupby go? i don't see groupby here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to explicitly import groupby/resample/window/indexing overrides because they don't trigger any modin.api.extensions.register_*_accessor
calls. Instead, we override the call to DataFrame.groupby()
, DataFrame.rolling
, and similar methods to just return a Snowpark pandas DataFrameGroupBy
/Window
object defined in groupby_overrides.py
/window_overrides.py
.
56fc701
to
7390b54
Compare
Good riddance to snowflake/snowpark/modin/pandas ! |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1672691
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR removes the snowflake/snowpark/modin/pandas folder. Remaining docstring paths have been modified appropriately, and necessary initialization code has moved to snowflake/snowpark/modin/plugin/init.py.
Previously, we exposed methods from
general_overrides
andio_overrides
as direct exports from thesnowflake.snowpark.modin.pandas
that were then mirrored into themodin.pandas
namespace. Now, we directly callmodin.pandas.api.extensions.register_pd_accessor
to populatemodin.pandas
.