-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-849605: fix datatype misalignment #1001
SNOW-849605: fix datatype misalignment #1001
Conversation
Is this all the misalignment we currently know of? |
if isinstance(result[c].sf_type.datatype, NullType): | ||
ret.append( | ||
Attribute( | ||
result[c].name if result[c].name else "NULL", StringType(), True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: Do we support multiple columns of the same name NULL
from describe
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you will get two columns of name NULL
by the following scripts:
df2 = session.create_dataframe([1, 2]).to_df("a").select(lit(None), lit(None))
assert len(df2.schema.fields) == 2
assert df2.schema.fields[0].datatype == StringType()
eba3789
to
79258cc
Compare
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #SNOW-849605
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.