SNOW-896744: Allow creating dataframes using tuples as schema #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sfan
requested changes
Aug 28, 2023
src/snowflake/snowpark/session.py
Outdated
| @@ -1865,7 +1865,7 @@ def write_pandas( | |||
| def create_dataframe( | |||
| self, | |||
| data: Union[List, Tuple, "pandas.DataFrame"], | |||
| schema: Optional[Union[StructType, List[str]]] = None, | |||
| schema: Optional[Union[StructType, List[str], Tuple[str]]] = None, | |||
There was a problem hiding this comment.
Should we make sure we use schema as an iterable when it is not StructType, and then support Iterable[str]?
| @@ -325,7 +325,7 @@ def infer_type(obj: Any) -> DataType: | |||
|
|
|||
|
|
|||
| def infer_schema( | |||
| row: Union[Dict, List, Tuple], names: Optional[List] = None | |||
| row: Union[Dict, List, Tuple], names: Optional[Union[List, Tuple]] = None | |||
There was a problem hiding this comment.
I don't think we could do names.extend when names is a tuple? How about we explicitly copy names into a list first? This way we could support Iterable.
There was a problem hiding this comment.
You are right. I can convert iterable into a list and then assume list datatype from thereon...
|
Did not mean to "requested changes". The change looks good overall but wonder if we could extend to |
sfc-gh-sfan
approved these changes
Aug 29, 2023
sfc-gh-aalam
deleted the
aalam-SNOW-896744-create-dataframe-with-tuple-schema
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-896744: creating a DataFrame with a tuple of names will be ignored an generic names will be used #1009
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.