Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1301084: Migrate jupyter notebook test workflow (VisualizingTaxiTripData nb) #1451

Merged

Conversation

sfc-gh-lmukhopadhyay
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1301084

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

Adds VisualizingTaxiTripData.ipynb notebook to tests/notebooks/modin and runs the notebook in daily github workflow using nbmake via daily_jupyter_nb_test.yml

Copy link

gitguardian bot commented Apr 29, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

github-actions bot commented Apr 29, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-lmukhopadhyay
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGELOG-UPDATES NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Apr 29, 2024
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay marked this pull request as ready for review April 30, 2024 16:41
.github/CODEOWNERS Outdated Show resolved Hide resolved
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay enabled auto-merge (squash) April 30, 2024 23:04
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay merged commit 476e2c9 into main May 1, 2024
26 checks passed
@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay deleted the lmukhopadhyay-SNOW-1301084-migrate-nb-test branch May 1, 2024 00:21
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants