Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1649528 Fix monotonic bug #2217

Merged
merged 1 commit into from
Sep 4, 2024
Merged

SNOW-1649528 Fix monotonic bug #2217

merged 1 commit into from
Sep 4, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1649528 Fix monotonic bug

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

This pull request includes several changes to improve the handling of monotonicity checks in the Snowflake Snowpark Modin integration and its corresponding tests. The most important changes include adding type checks for monotonicity, refining the logic for monotonicity checks in the query compiler, and expanding test cases to cover more scenarios.

Improvements to Monotonicity Checks:

Refinements in Query Compiler:

Expanded Test Cases:

@sfc-gh-azhan sfc-gh-azhan added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 3, 2024
@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner September 3, 2024 22:11
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thanks! But can you add a changelog entry under Bug Fixes?

@sfc-gh-azhan
Copy link
Collaborator Author

Looks good overall. Thanks! But can you add a changelog entry under Bug Fixes?

I didn't do because this feature has not been released yet.

@sfc-gh-azhan sfc-gh-azhan merged commit fe506ac into main Sep 4, 2024
34 of 35 checks passed
@sfc-gh-azhan sfc-gh-azhan deleted the azhan-fix-mono-1649528 branch September 4, 2024 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants