Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1738538 Update test expectations to textproto ast for better stability and readability #2464

Merged
merged 7 commits into from
Oct 23, 2024
Merged

SNOW-1738538 Update test expectations to textproto ast for better stability and readability #2464

merged 7 commits into from
Oct 23, 2024

Conversation

sfc-gh-evandenberg
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg commented Oct 16, 2024 •
edited
Loading

Fixes SNOW-1738538 Update test expectations to textproto ast for better stability and readability

@sfc-gh-evandenberg sfc-gh-evandenberg requested a review from a team as a code owner October 16, 2024 19:53
@sfc-gh-evandenberg sfc-gh-evandenberg force-pushed the evandenberg-SNOW-1738538-update-expectations-to-json-ast branch from 942b880 to 50efcb7 Compare October 22, 2024 20:15
sfc-gh-oplaton
sfc-gh-oplaton approved these changes Oct 23, 2024
View reviewed changes
Copy link

@sfc-gh-oplaton sfc-gh-oplaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I think the PR title needs updating (json ast -> textproto AST)

@sfc-gh-evandenberg sfc-gh-evandenberg changed the title SNOW-1738538 Update test expectations to json ast for better stability and readability SNOW-1738538 Update test expectations to textproto ast for better stability and readability Oct 23, 2024
@sfc-gh-evandenberg sfc-gh-evandenberg merged commit e843c05 into ls-SNOW-1491199-merge-phase0-server-side Oct 23, 2024
32 of 37 checks passed
@sfc-gh-evandenberg sfc-gh-evandenberg deleted the evandenberg-SNOW-1738538-update-expectations-to-json-ast branch October 23, 2024 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-oplaton sfc-gh-oplaton sfc-gh-oplaton approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-vbudati sfc-gh-vbudati Awaiting requested review from sfc-gh-vbudati

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg Awaiting requested review from sfc-gh-lspiegelberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-evandenberg @sfc-gh-lspiegelberg @sfc-gh-oplaton