-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1738538 Update test expectations to textproto ast for better stability and readability #2464
Merged
sfc-gh-evandenberg
merged 7 commits into
ls-SNOW-1491199-merge-phase0-server-side
from
evandenberg-SNOW-1738538-update-expectations-to-json-ast
Oct 23, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-evandenberg
requested review from
sfc-gh-jdu,
sfc-gh-yuwang,
sfc-gh-jrose,
sfc-gh-lspiegelberg,
sfc-gh-vbudati and
sfc-gh-oplaton
and removed request for
a team
October 16, 2024 19:53
sfc-gh-evandenberg
force-pushed
the
evandenberg-SNOW-1738538-update-expectations-to-json-ast
branch
from
October 22, 2024 20:15
942b880
to
50efcb7
Compare
sfc-gh-evandenberg
requested review from
sfc-gh-lspiegelberg and
sfc-gh-oplaton
October 22, 2024 22:47
sfc-gh-oplaton
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I think the PR title needs updating (json ast
-> textproto AST
)
sfc-gh-evandenberg
changed the title
SNOW-1738538 Update test expectations to json ast for better stability and readability
SNOW-1738538 Update test expectations to textproto ast for better stability and readability
Oct 23, 2024
sfc-gh-evandenberg
merged commit Oct 23, 2024
e843c05
into
ls-SNOW-1491199-merge-phase0-server-side
32 of 37 checks passed
sfc-gh-evandenberg
deleted the
evandenberg-SNOW-1738538-update-expectations-to-json-ast
branch
October 23, 2024 18:11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SNOW-1738538 Update test expectations to textproto ast for better stability and readability