Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1732087] Fix doctest file descriptor capture. #2490

Merged
merged 8 commits into from
Oct 23, 2024
Merged

[SNOW-1732087] Fix doctest file descriptor capture. #2490

merged 8 commits into from
Oct 23, 2024

Conversation

sfc-gh-lspiegelberg
Copy link
Contributor

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg commented Oct 22, 2024 •
edited
Loading

Fixes doctest for phase0 with --ast-enabled by switching the runner to macOS and fixing up various logging.<func> usages by switching them to _logger as in the rest of the code base. Doctest do not pass at the moment (error: returning , interference with logging module, cf. JIRA) under ubuntu (windows: not tested).

Other:

  • warn for missing unparser.jar file now only if --update-expectations is passed.
  • Use file-specific logger instead of global loggers.

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg changed the base branch from main to ls-SNOW-1491199-merge-phase0-server-side October 22, 2024 20:15
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg changed the title [DRAFT] [SNOW-1732087] Fix doctest file descriptor capture. [SNOW-1732087] Fix doctest file descriptor capture. Oct 23, 2024
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg marked this pull request as ready for review October 23, 2024 20:47
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg merged commit 15cabe0 into ls-SNOW-1491199-merge-phase0-server-side Oct 23, 2024
6 checks passed
@sfc-gh-lspiegelberg sfc-gh-lspiegelberg deleted the ls-SNOW-1732087-fix-doctest branch October 23, 2024 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-oplaton sfc-gh-oplaton sfc-gh-oplaton approved these changes

@sfc-gh-vbudati sfc-gh-vbudati Awaiting requested review from sfc-gh-vbudati

@sfc-gh-azwiegincew sfc-gh-azwiegincew Awaiting requested review from sfc-gh-azwiegincew

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Awaiting requested review from sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-lspiegelberg @sfc-gh-oplaton