-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-1844465] Avoid creating a CTE out of simple select start on top of a select entity #2713
Conversation
pandas daily job started https://ci-dev-142.int.snowflakecomputing.com/job/SnowparkPythonSnowPandasDailyRegressRunner/1087/ snowpark daily job started https://github.com/snowflakedb/snowpark-python/actions/runs/12170949440 |
# complexity_score = id_complexity_map[node_id] | ||
repeated_count = len(id_node_map[node_id]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# complexity_score = id_complexity_map[node_id] | |
repeated_count = len(id_node_map[node_id]) | |
repeated_count = len(id_node_map[node_id]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
# id_complexity_map: Dict[str, int], | ||
id_node_map: Dict[str, List["TreeNode"]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# id_complexity_map: Dict[str, int], | |
id_node_map: Dict[str, List["TreeNode"]], | |
id_node_map: Dict[str, List["TreeNode"]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to push the new change, removed
36792e4
to
85562f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
85562f0
to
2a460f3
Compare
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1844465
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
The CTE optimization today will create a CTE out of a simple select * from TABLE, improve teh CTE by exclude such usage.