Skip to content

SNOW-1871755: Support more snowflake built-in functions #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 14, 2025

Conversation

sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Dec 11, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

implement 26 missing built-in functions

  - `acosh`
  - `asinh`
  - `atanh`
  - `bit_length`
  - `bitmap_bit_position`
  - `bitmap_bucket_number`
  - `bitmap_construct_agg`
  - `cbrt`
  - `equal_null`
  - `ifnull`
  - `localtimestamp`
  - `max_by`
  - `min_by`
  - `nvl`
  - `octet_length`
  - `position`
  - `regr_avgx`
  - `regr_avgy`
  - `regr_count`
  - `regr_intercept`
  - `regr_r2`
  - `regr_slope`
  - `regr_sxx`
  - `regr_sxy`
  - `regr_syy`
  - `try_to_binary`

@sfc-gh-aling sfc-gh-aling changed the title test impl SNOW-1871755: Support more snowflake built-in functions Jan 9, 2025
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review January 9, 2025 18:44
@sfc-gh-aling sfc-gh-aling requested review from a team as code owners January 9, 2025 18:44
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits.

@sfc-gh-aling sfc-gh-aling enabled auto-merge (squash) January 14, 2025 17:05
@sfc-gh-aling sfc-gh-aling merged commit e40ac0b into main Jan 14, 2025
39 of 40 checks passed
@sfc-gh-aling sfc-gh-aling deleted the feature/aling-bulk-function-dev branch January 14, 2025 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants