-
Notifications
You must be signed in to change notification settings - Fork 130
SNOW-1800374: adding support for options and partition_by to dataframewriter #2841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, left some comments. Ping me once it is ready for merge for the final approval!
8dcc4fb
to
8c4046c
Compare
tests/ast/data/DataFrame.write.test
Outdated
@@ -44,6 +50,12 @@ df.write.save_as_table("saved_table") | |||
|
|||
df.write.mode("overwrite").save_as_table("saved_table", table_type="temporary") | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some repeated calls of .mode(...)
, .option(...)
, .options(...)
? Just to clarify behavior and preserve for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one ask/nit to clarify behavior for repeated calls.
1ad6d8a
to
eafe4dd
Compare
3b46bf4
to
a171b24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for adding more test cases as well!
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1800374
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.